Update multiple services example #13265
Conversation
|
I like the idea but would not add the Logger in this example, yes it makes sense but complicated the example itself |
|
Hello @OskarStark , thank you for your feedback! I have 3 propositions:
|
|
Please use the same example as before, no need for a try catch here, it’s just an example and should not distract by things which are not needed. Using // ... Is fine too, meaning there could be some other code parts around. Thanks Edit: If you have further questions or sth is unclear please feel free to ping me again and I can provide the full example. I am currently on a phone 📲 |
carsonbot
added
Status: Needs Review
and removed
Status: Needs Work
Status: Reviewed
labels
| } | ||
| } | ||
|
|
||
| This needs the ``MessageGenerator`` *and* the ``Swift_Mailer`` service. That's no | ||
| This needs the ``MessageGenerator`` *and* the ``Mailer`` service. That's no |
There was a problem hiding this comment.
Idk, I'm a little sceptical about this change. We call the Mailer service through the MailerInterface no?
Would't this sound better ?
This needs the
MessageGeneratorand theMailerservice. That's no
problem, we ask them by type-hinting their class and interface names!
…er (lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- Fixed CoverageListener usage with custom SUT solver Commits ------- aeb4053 Fixed CoverageListener usage with custom SUT solver
* 3.4: Fixed CoverageListener usage with custom SUT solver
formating improve
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes symfony#13237). Discussion ---------- Update messenger.rst formating improve <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 73e088c Update messenger.rst
This PR propose to replace SwiftMailer with the Mailer component and to add the Logger service for a better understanding how to inject multiple services
|
Thanks Romain. |
This PR propose to replace SwiftMailer with the Mailer component and to add the Logger service for a better understanding how to inject multiple services